-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add set rcv buffer for syncd rpc #64
Add set rcv buffer for syncd rpc #64
Conversation
@@ -44,5 +44,6 @@ COPY supervisord.conf /etc/supervisor/conf.d/supervisord.conf | |||
COPY ptf_nn_agent.conf /etc/supervisor/conf.d/ptf_nn_agent.conf | |||
|
|||
ENTRYPOINT service rsyslog start \ | |||
&& sysctl -w net.core.rmem_max=509430500 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
magic number
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you want to see here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why you choose this magic number?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found this number experimentally. I can round it to some value, let say 500000000. Will it work for you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, thanks!
@@ -1,5 +1,5 @@ | |||
[program:ptf_nn_agent] | |||
command=/usr/bin/python /opt/ptf_nn_agent.py --device-socket 1@tcp://0.0.0.0:10900 -i 1-3@Ethernet12 | |||
command=/usr/bin/python /opt/ptf_nn_agent.py --device-socket 1@tcp://0.0.0.0:10900 -i 1-3@Ethernet12 --set-iface-rcv-buffer=109430400 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
magic number
@@ -44,5 +44,6 @@ COPY supervisord.conf /etc/supervisor/conf.d/supervisord.conf | |||
COPY ptf_nn_agent.conf /etc/supervisor/conf.d/ptf_nn_agent.conf | |||
|
|||
ENTRYPOINT service rsyslog start \ | |||
&& sysctl -w net.core.rmem_max=509430500 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do 'sysctl' inside container? should we do it on host as init script?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because it makes sense and bound to the processes which lives inside of the container.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If bounded, should roll back the effect after container dies. How about container's systemd file if really bounded.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it matter for the container which is used only in tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no big deal for test.
@@ -44,5 +44,6 @@ COPY supervisord.conf /etc/supervisor/conf.d/supervisord.conf | |||
COPY ptf_nn_agent.conf /etc/supervisor/conf.d/ptf_nn_agent.conf | |||
|
|||
ENTRYPOINT service rsyslog start \ | |||
&& sysctl -w net.core.rmem_max=509430500 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for this line, what about add it to the sonic-mgmt or put it into the systemctl file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's wrong with this line? Can you please explain it further?
I don't see any rationale to put this line into the host-machine level (systemd). In this case we will have two base systems (for tests and for production).
Also I don't see any rationale to change this systemctl before the tests, then restart ptf_nn_agent, then change it back again and restart ptf_nn_agent again.
…te submodules (#4852) * src/sonic-platform-common 75698a8...82bbeab (9): > [sfputil] Make SfpUtilHelper.get_physical_to_logical noexcept as in SfpUtilBase (#96) > [sfp_base] Update return value documentation of channel-specific methods (#98) > [sfp] Tweak key names of some transceiver info fields (#97) > fix typo: portconfig.ini to port_config.ini (#94) > [chassis_base] Add platform API support for system LED (#91) > Add PCIe check commad (#64) > [sfputilbase.py] Don't try to print EEPROM sysfs file name if we failed to read from it (#81) > [sfputilbase | sfputilhelper] Add support of platform.json (#72) > [eeprom] Add try-except to catch the IOError (#85) * src/sonic-platform-daemons 0f4fd83...abe115e (2): > [xcvrd] Tweak some transceiver info key names (#62) > [psud][thermalctld] Always get fan/PSU LED status from platform API to avoid status inconsistencies (#59) * src/sonic-utilities fd7781b...16a33f2 (9): > [config] Fix syntax error (#966) > [config] Fix indentation level in _get_disabled_services_list() (#965) > a4e64d1 [sonic_installer] Refactor sonic_installer code (#953) > 90efd62 [Show | Command Reference] Add Port breakout Show Command (#859) > [sfpshow][mock_state_db] Tweak key names of some transceiver info fields (#958) > [show] Add missing verbose option to "show line" (#961) > [filter-fdb] Check VLAN Presence When Filter FDB (#957) > [master]fix #4716 show ipv6 interfaces neighbor_ip is N/A issue (#948) > Fix for command. show interface transceiver eeprom -d Ethernet (#955) Note: sonic-utilities update fixes #4716
…te submodules (sonic-net#4852) * src/sonic-platform-common 75698a8...82bbeab (9): > [sfputil] Make SfpUtilHelper.get_physical_to_logical noexcept as in SfpUtilBase (sonic-net#96) > [sfp_base] Update return value documentation of channel-specific methods (sonic-net#98) > [sfp] Tweak key names of some transceiver info fields (sonic-net#97) > fix typo: portconfig.ini to port_config.ini (sonic-net#94) > [chassis_base] Add platform API support for system LED (sonic-net#91) > Add PCIe check commad (sonic-net#64) > [sfputilbase.py] Don't try to print EEPROM sysfs file name if we failed to read from it (sonic-net#81) > [sfputilbase | sfputilhelper] Add support of platform.json (sonic-net#72) > [eeprom] Add try-except to catch the IOError (sonic-net#85) * src/sonic-platform-daemons 0f4fd83...abe115e (2): > [xcvrd] Tweak some transceiver info key names (sonic-net#62) > [psud][thermalctld] Always get fan/PSU LED status from platform API to avoid status inconsistencies (sonic-net#59) * src/sonic-utilities fd7781b...16a33f2 (9): > [config] Fix syntax error (sonic-net#966) > [config] Fix indentation level in _get_disabled_services_list() (sonic-net#965) > a4e64d1 [sonic_installer] Refactor sonic_installer code (sonic-net#953) > 90efd62 [Show | Command Reference] Add Port breakout Show Command (sonic-net#859) > [sfpshow][mock_state_db] Tweak key names of some transceiver info fields (sonic-net#958) > [show] Add missing verbose option to "show line" (sonic-net#961) > [filter-fdb] Check VLAN Presence When Filter FDB (sonic-net#957) > [master]fix sonic-net#4716 show ipv6 interfaces neighbor_ip is N/A issue (sonic-net#948) > Fix for command. show interface transceiver eeprom -d Ethernet (sonic-net#955) Note: sonic-utilities update fixes sonic-net#4716
Update the patform daemons with new commits commit e9628b6 Merge pull request #64 from judyjoseph/multi_asic_ledd_xcvr * platform daemon (Xcvrd, Ledd) changes for multi asic platform * Updates in ledd daemon to use namespaces and get the namespace from selector object. * Updates to xcvrd daemon to use the asic_id in talking to the right DB. * Updated based on new sonic-py-common API's * Invoke initializeGlobalConfig() in the SfpUpdate/DomInfoUpdate processes as well. commit 415b8c4 [thermalctld] Optimize the thermal policy loop to make it execute every 60 seconds (#77) commit 3d1f319 Update FAN_INFO in psud to avoid inconsistant output of show platform psud and show platform fan (#81)
[MultiDB] shoule use multiDB API (#57) [Thermal] Fix for 'show platform fan' command (#71) [xcvrd] Return non-zero error code on SFP error (#67) Multi-asic changes commit (PR #64 ) into 201911 [ledd][multi-ASIC] Update to ledd based on sonic-swss-common updates (#87) Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
* Add pcie_base and pcie_common function * Add pcie_base and pcie_common function * Add pcie_base and pcie_common funtion * modify format * modify prompt message * modify prompt message
- Locking openconfig/gnmi to the known good version. (#64)
Update the patform daemons with new commits commit e9628b6 Merge pull request sonic-net#64 from judyjoseph/multi_asic_ledd_xcvr * platform daemon (Xcvrd, Ledd) changes for multi asic platform * Updates in ledd daemon to use namespaces and get the namespace from selector object. * Updates to xcvrd daemon to use the asic_id in talking to the right DB. * Updated based on new sonic-py-common API's * Invoke initializeGlobalConfig() in the SfpUpdate/DomInfoUpdate processes as well. commit 415b8c4 [thermalctld] Optimize the thermal policy loop to make it execute every 60 seconds (sonic-net#77) commit 3d1f319 Update FAN_INFO in psud to avoid inconsistant output of show platform psud and show platform fan (sonic-net#81)
…TERS_DB (sonic-net#51)" (sonic-net#57)" (sonic-net#64) This reverts commit 022d8fb. Add sonic-net#51 back in by reverting sonic-net#57, in because issues should be addressed by the merge of sonic-net/sonic-swss#1124
* platform daemon (Xcvrd, Ledd) changes for multi asic platform * Updates in ledd daemon to use namespaces and get the namespace from selector object. * Updates to xcvrd daemon to use the asic_id in talking to the right DB. * Updated based on new sonic-py-common API's * Invoke initializeGlobalConfig() in the SfpUpdate/DomInfoUpdate processes as well.
Updated TPCM document
[master][sonic-linkmgrd] submodule updates df51322 Longxiang Lyu Fri May 6 10:01:46 2022 +0800 Add `ActiveActiveStateMachine` implementation (#64) e721ceb Jing Zhang Wed May 4 10:07:14 2022 -0700 Add doc for default route related changes (#63) 7bb06fb Jing Zhang Tue May 3 09:48:28 2022 -0700 Add Cli support to enable or disable default route related feature (#68) e4b02cb Jing Zhang Mon May 2 13:27:54 2022 -0700 Reset WaitActiveUp count before switching to active (#70) 212d960 Jing Zhang Wed Apr 27 10:35:05 2022 -0700 lower log level to warning (#69) 48abc9e Jing Zhang Thu Apr 14 16:50:04 2022 -0700 Add support to enable switchover time measurement (with link prober interval decreased to 10ms) feature (#61) c4858a6 Jing Zhang Thu Apr 14 11:27:55 2022 -0700 Avoid proactively switching to `active` if default route is missing (#62) sign-off: Jing Zhang zhangjing@microsoft.com
Include following changes; * 3c2b546 2022-05-31 | Add default route support to `active-active` state machine (sonic-net#78) (github/master, github/202205, master, 202205) [Jing Zhang] * 6fa892e 2022-05-27 | Degrade `LinkProberStateMachineBase` virtual function logging level (sonic-net#80) [Longxiang Lyu] * 7b695ca 2022-05-27 | Fix mux wait timer and peer mux wait timer (sonic-net#81) [Longxiang Lyu] * d744bfb 2022-05-25 | Support switch between using wellknown mac or server mac addr (sonic-net#73) [Longxiang Lyu] * 684e989 2022-05-18 | Avoid switching active when `LinkState == Down` (sonic-net#77) [Jing Zhang] * e4aa4fd 2022-05-17 | [Makefile] Remove redundant optimization options (sonic-net#75) [Longxiang Lyu] * 4ec7505 2022-05-12 | [ci]: uplift diff coverage threshold to 80% (sonic-net#71) [Jing Zhang] * df51322 2022-05-06 | Add `ActiveActiveStateMachine` implementation (sonic-net#64) [Longxiang Lyu] * e721ceb 2022-05-04 | Add doc for default route related changes (sonic-net#63) [Jing Zhang] * 7bb06fb 2022-05-03 | Add Cli support to enable or disable default route related feature (sonic-net#68) [Jing Zhang] * e4b02cb 2022-05-02 | Reset WaitActiveUp count before switching to active (sonic-net#70) [Jing Zhang] * 212d960 2022-04-27 | lower log level to warning (sonic-net#69) [Jing Zhang] * 48abc9e 2022-04-14 | Add support to enable switchover time measurement (with link prober interval decreased to 10ms) feature (sonic-net#61) [Jing Zhang] * c4858a6 2022-04-14 | Avoid proactively switching to `active` if default route is missing (sonic-net#62) [Jing Zhang] * 41f5fb9 2022-04-11 | Upgrade linkmgrd to `BULLSEYE` (sonic-net#60) [Jing Zhang] Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Include following changes; * 3c2b546 2022-05-31 | Add default route support to `active-active` state machine (#78) (github/master, github/202205, master, 202205) [Jing Zhang] * 6fa892e 2022-05-27 | Degrade `LinkProberStateMachineBase` virtual function logging level (#80) [Longxiang Lyu] * 7b695ca 2022-05-27 | Fix mux wait timer and peer mux wait timer (#81) [Longxiang Lyu] * d744bfb 2022-05-25 | Support switch between using wellknown mac or server mac addr (#73) [Longxiang Lyu] * 684e989 2022-05-18 | Avoid switching active when `LinkState == Down` (#77) [Jing Zhang] * e4aa4fd 2022-05-17 | [Makefile] Remove redundant optimization options (#75) [Longxiang Lyu] * 4ec7505 2022-05-12 | [ci]: uplift diff coverage threshold to 80% (#71) [Jing Zhang] * df51322 2022-05-06 | Add `ActiveActiveStateMachine` implementation (#64) [Longxiang Lyu] * e721ceb 2022-05-04 | Add doc for default route related changes (#63) [Jing Zhang] * 7bb06fb 2022-05-03 | Add Cli support to enable or disable default route related feature (#68) [Jing Zhang] * e4b02cb 2022-05-02 | Reset WaitActiveUp count before switching to active (#70) [Jing Zhang] * 212d960 2022-04-27 | lower log level to warning (#69) [Jing Zhang] * 48abc9e 2022-04-14 | Add support to enable switchover time measurement (with link prober interval decreased to 10ms) feature (#61) [Jing Zhang] * c4858a6 2022-04-14 | Avoid proactively switching to `active` if default route is missing (#62) [Jing Zhang] * 41f5fb9 2022-04-11 | Upgrade linkmgrd to `BULLSEYE` (#60) [Jing Zhang] Signed-off-by: Ying Xie <ying.xie@microsoft.com>
[master][sonic-linkmgrd] submodule updates df51322 Longxiang Lyu Fri May 6 10:01:46 2022 +0800 Add `ActiveActiveStateMachine` implementation (#64) e721ceb Jing Zhang Wed May 4 10:07:14 2022 -0700 Add doc for default route related changes (#63) 7bb06fb Jing Zhang Tue May 3 09:48:28 2022 -0700 Add Cli support to enable or disable default route related feature (#68) e4b02cb Jing Zhang Mon May 2 13:27:54 2022 -0700 Reset WaitActiveUp count before switching to active (#70) 212d960 Jing Zhang Wed Apr 27 10:35:05 2022 -0700 lower log level to warning (#69) 48abc9e Jing Zhang Thu Apr 14 16:50:04 2022 -0700 Add support to enable switchover time measurement (with link prober interval decreased to 10ms) feature (#61) c4858a6 Jing Zhang Thu Apr 14 11:27:55 2022 -0700 Avoid proactively switching to `active` if default route is missing (#62) sign-off: Jing Zhang zhangjing@microsoft.com
Update sonic-mgmt-common submodule pointer to include the following: * 68e0341 Remove LOGLEVEL DB since is no longer used ([sonic-net#64](sonic-net/sonic-mgmt-common#64)) Signed-off-by: dprital <drorp@nvidia.com>
Update sonic-mgmt-common submodule pointer to include the following: 68e0341 Remove LOGLEVEL DB since is no longer used (sonic-net#64) Signed-off-by: dprital <drorp@nvidia.com>
This PR is part of the following HLD: Persistent loglevel HLD: sonic-net/SONiC#1041 **- What I did** Deleted the LOGLEVEL_DB. After the Logger tables moved from the LOGLEVEL_DB to the CONFIG_DB and the jinja2_cache was deleted the LOGLEVEL_DB is not in use. **- How I did it** Removed the LOGLEVEL_DB from the SONiC code **- How to verify it** All tests were passed
[code sync] Merge code from sonic-net/sonic-buildimage:202205 to 202205
…ically (#19769) #### Why I did it src/sonic-dbsyncd ``` * 5956f0b - (HEAD -> 202311, origin/202311) Handle exception to avoid lldp_syncd crash (#65) (60 minutes ago) [Zhaohui Sun] * d89a00d - [lldp-syncd] Fix unexpected exception in snmp-subagent (#64) (10 hours ago) [Zhaohui Sun] ``` #### How I did it #### How to verify it #### Description for the changelog
d5fa793: Handle exception to avoid lldp_syncd crash (sonic-net#65) bc63571: Fix pipeline issue. (sonic-net#66) 4d627ee: [lldp-syncd] Fix unexpected exception in snmp-subagent (sonic-net#64) e294eb0: Update the code coverage rate to 80% (sonic-net#63)
No description provided.